RFR(XXS): 8043158: Crash in CodeSweeperSweepNoFlushTest in CompileQueue::free_all()
christian.thalinger at oracle.com
Thu Jun 19 20:07:15 UTC 2014
Alright, I trust you on this :-) Looks good.
On Jun 17, 2014, at 6:52 AM, Albert <albert.noll at oracle.com> wrote:
> Hi Chris,
> thanks for looking at this. We use the lock if:
> 1) we wait for a compilation task to complete (background compilation disabled).
> 2) we mark a compilation task to be complete (background compilation disabled).
> I don't think that a deadlock is possible.
> On 06/06/2014 04:41 PM, Christian Thalinger wrote:
>> Who else can hold that lock? Is there a dead-lock possibility?
>> On Jun 6, 2014, at 1:17 AM, Albert <albert.noll at oracle.com> wrote:
>>> could I get reviews for this small patch?
>>> In CompileQueue::free_all() we call notify() on a compile task although we do not own the
>>> lock of the compile task object.
>>> Acquire lock before calling notify()
>>> Failing test case
>>> Many thanks in advance,
More information about the hotspot-compiler-dev