RFR(S): 8060479: [TESTBUG] compiler/codecache/CheckSegmentedCodeCache.java test fails with product build
tobias.hartmann at oracle.com
Thu Oct 16 09:40:57 UTC 2014
On 15.10.2014 19:37, David Chase wrote:
> Hello Tobias,
> I am not a Reviewer, but that looks good to me.
> I would add a comment to the bug itself making sure that you clarify what is going on.
> Current text overuses the word “failure” without making it “clear” that the “failure” is a failure to fail;
> that the test is verifies that the VM will exit with an error when the code cache is too small,
> but in turns out that a release VM can run in a small enough code cache that the size used
> by the test is in fact, not too small, and thus no error is seen, and thus the test is judged to have failed.
> I’m not sure I was any better at explaining it :-(.
> The intent is to make someone less puzzled when they look at this six months from now.
Thanks for the suggestion. I updated the bug description to make it more
explicit that this is a test bug. I also added the appropriate labels and a link
to a JPRT run with the fixed test.
> On 2014-10-15, at 10:19 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
>> please review the following patch.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8060479
>> Webrev: http://cr.openjdk.java.net/~thartmann/8060479/webrev.00/
>> The test CheckSegmentedCodeCache assumes that VM startup always fails with a ReservedCodeCacheSize of 1700K. This is not true for product builds (see 'min_code_cache_size' in 'CodeCache::initialize_heaps()').
>> Check for debug build and adjust minimum code cache size accordingly.
>> Failing test on JPRT.
More information about the hotspot-compiler-dev