RFR(S): 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method
igor.ignatyev at oracle.com
Fri Oct 24 13:06:06 UTC 2014
1. could you please make 'method' an instance field?
2. use AssertionError instead of RuntimeException
3. have you tried to run this test w/ Xcomp?
On 10/24/2014 04:39 PM, Tobias Hartmann wrote:
> please review the following patch.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8061817
> Webrev: http://cr.openjdk.java.net/~thartmann/8061817/webrev.00/
> 'WhiteBox.deoptimizeMethod' does not deoptimize all OSR compiled versions of the
> given method but only one. The problem lies in'WB_DeoptimizeMethod'. The call to
> 'lookup_osr_nmethod_for' only returns the best fitting OSR nmethod. Incrementing
> the bci (see line 395) does not help.
> I changed the implementation to deoptimize all OSR versions and added a
> regression test that triggers two OSR compilations and checks that both are
> deoptimized ('DeoptimizeMultipleOSRTest').
> New test on JPRT
More information about the hotspot-compiler-dev