RFR(XS) : 8036913 : make DeoptimizeALot dependent on number of threads
igor.ignatyev at oracle.com
Thu Oct 30 00:02:57 UTC 2014
thanks for review.
the updated webrev w/ the comment:
11 lines changed: 3 ins; 3 del; 5 mod;
On 10/29/2014 05:48 PM, Vladimir Kozlov wrote:
> On 10/29/14 6:49 AM, Igor Ignatyev wrote:
>> zombie/deoptimizeAllCounter are invocation counters of corresponding
>> function and not counters of the actually happened
>> events. so they should be incremented on each invocation of the function.
> Please, add this explanation as a comment so it would be clear why you
> divide by number of threads.
> Changes are fine with that.
>> On 10/28/2014 09:41 PM, Aleksey Shipilev wrote:
>>> On 28.10.2014 21:22, Igor Ignatyev wrote:
>>>> 8 lines changed: 2 ins; 2 del; 4 mod;
>>> Looks good.
>>>> + zombieAllCounter incrementation is moved out of if-else to be aligned
>>>> w/ deoptimizeAllCounter
>>> Shouldn't it be in reverse, i.e. deoptimizeAllCounter to be moved in the
>>> block? I would think counting the _successful_ deoptimizeAll/zombieAll
>>> events is more useful.
More information about the hotspot-compiler-dev