RFR(M): 8054889 - Additional Compiler Diagnostic commands
nils.eliasson at oracle.com
Fri Sep 5 14:08:07 UTC 2014
On 2014-09-05 15:27, Albert wrote:
> Hi Nils,
> I looked at your changes. Here is some feedback:
> - Would it make sense to add an assert in ' CompileQueue::print()'
> that checks that we are either at a safepoint or that the
> MethodCompileQueue_lock is held?
> ( assert_locked_or_safepoint(CodeCache_lock);). This seems to make
> the implementation more robust.
Yes - certainly. Fixed.
> - CodeCache::print_codelist() iterates over all 'alive' nmethods.
> However, the description says:
> 'Print all compiled methods in code cache.' I think either the
> description or the implementation should be adapted to keep things
Good. Yes it make more sense to print all nmethods.
I also found that I had forgotten to add a file
New webrev here:
> On 09/05/2014 01:12 PM, Nils Eliasson wrote:
>> This fix introduces three new diagnostic commands and corresponding
>> tests. The commands are Compiler.queue for printing the contents of
>> the compiler queue, Compiler.codelist for printing all nmethods in
>> the codecache and Compiler.codecache for printing an informational
>> code cache summary.
>> Description here:
>> Nils Eliasson
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev