RFR(S): 8025606: [TESTBUG] Move ctw-tests to /testlibrary_tests
evgeniya.stepanova at oracle.com
Thu Sep 18 08:02:40 UTC 2014
Thanks for review!
Igor, could you please push changes to the repo?
On 17.09.2014 20:58, Vladimir Kozlov wrote:
> On 9/17/14 2:36 AM, Igor Ignatyev wrote:
>>> What about testlibrary/ctw/Makefile? Should we move/modify it?
>> we don't need to move or modify Makefile, since it doesn't contain
>> any references to tests.
>>> Do we need it at all?
>> it depends on point of view, hotspot doesn't require it to build (as
>> well as testlibrary/whitebox/Makefile), but I'd
>> prefer to leave them, since the intent why I added these Makefiles
>> was to generate ctw.jar/wb.jar from hotpost sources
>> during the build cycle of another testbase, e.g. vm testbase, ctw.
> Okay. Changes look fine then.
>> On 09/17/2014 12:30 PM, Vladimir Kozlov wrote:
>>> What about testlibrary/ctw/Makefile? Should we move/modify it? Do we
>>> need it at all?
>>> On 9/17/14 12:43 AM, Evgeniya Stepanova wrote:
>>>> Please review this small patch.
>>>> Tests for testlibrary moved to testlibrary_tests to exclude them from
>>>> the classpath when running other tests
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8025606
>>>> /Evgeniya Stepanova/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev