RFR(M): 8044186 Introduce a reproducible random generator

Sergei Kovalev sergei.kovalev at oracle.com
Mon Sep 22 15:10:22 UTC 2014

I applied all remarks.

Please take a look: 

On 20.09.2014 01:03, Igor Ignatyev wrote:
> Hi Sergei,
> test/testlibrary/com/oracle/java/testlibrary/Utils.java:
> don't you need an additional check RANDOM_GENERATOR == null after line 
> #355 to prevent double creating of Random which leads to the problems 
> w/ reproducing on MT environments?
> Thanks,
> Igor
> On 09/19/2014 05:57 PM, Sergei Kovalev wrote:
>> Hi All,
>> I'm working for CR https://bugs.openjdk.java.net/browse/JDK-8044186 that
>> submitted against tests.
>> There's the several tests which use randomly generated numbers. It's
>> needed to introduce a way that provide a common manner to reproduce the
>> same random sequence, set seed.
>> There are two possible way to provide seed value:
>> - system property
>> - command line arguments.
>> I chose system property to provide seed value because it could be
>> obtained in any part of code without additional effort. In case passing
>> seed value as command line argument we have to introduce additional
>> logic (and unwanted code) to pass this value in appropriate method.
>> I introduced factory method getRandomInstance in the file Utility.java
>> and make reference to this method in all applicable tests.
>> There is other utility class: Verifier.java. It used in several other
>> testcases from test/compiler/intrinsics/mathexact/ package. Therefore
>> many files contains modifications only for jtreg annotations.
>> I've tested all related tests locally. All tests passed and seed value
>> printed to the logs.
>> links:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8044186
>> webrev: http://cr.openjdk.java.net/~vlivanov/kovalev/8044186/webrev.00/

With best regards,

More information about the hotspot-compiler-dev mailing list