RFR(M): 8069035: compiler/oracle/CheckCompileCommandOption.java nightly failure
zoltan.majo at oracle.com
Fri Jan 16 14:34:09 UTC 2015
in general, your changes look good to me (I'm not a Reviewer). Please
see my comments below.
On 01/15/2015 08:23 PM, Nils Eliasson wrote:
> Please review this change. The push of JDK-8027829 caused a nightly
> failure. The fix for allowing the signature to follow the method
> without a whitespace wasn't complete and broke the option parsing.
> This change includes these fixes:
> * Fixing the removal of whitespace in option command parsing
> * Adding the test to TEST.groups (~7s test time on a fast machine)
I agree with Albert that it might be better to execute the
test/compiler/oracle/CheckCompileCommandOption.java only in nightlies.
Especially that the test might take much longer on the slower machines
that we have.
> * Added additional test cases for the CompilerCommandFile
That is a good idea, but I think you've forgotten to include those
command files into the webrev. As a result, when I run the test with
jtreg on my own machine, it fails with the following error message:
STATUS:Failed.`main' threw exception: java.lang.RuntimeException:
'CompileCommand: option com/oracle/Test.test bool MyBoolOption1 = true'
missing from stdout/stder
Thank you and best regards,
> * Added testcases for option parsing together with a method pattern
> that includes a signature
> * Moved some testcases together that didn't require separate VMs
> Bug: https://bugs.openjdk.java.net/browse/JDK-8069035
> Webrev: http://cr.openjdk.java.net/~neliasso/8069035/webrev.01
> Best regards,
> Nils Eliasson
More information about the hotspot-compiler-dev