[9] RFR(S): 8059606: Enable per-method usage of CompileThresholdScaling (per-method compilation thresholds)

Zoltán Majó zoltan.majo at oracle.com
Tue Jan 20 13:29:36 UTC 2015

Hi John,

thank you for the feedback!

On 01/19/2015 09:15 PM, John Rose wrote:
> The comments in globals.hpp are good, but watch the spacing.  String 
> concatenation will cause some words to run into each other.  This 
> isn't very important, but it might show up with java 
> -XX:+PrintFlagsWithComments (in a debug build).

Thank you for catching that. I updated the comments and now they are 
printed OK with -XX:+PrintFlagsWithComment.

>> Here is the new 
>> webrev:http://cr.openjdk.java.net/~zmajo/8059606/webrev.03/ 
>> <http://cr.openjdk.java.net/%7Ezmajo/8059606/webrev.03/>
> Reviewed; it's good.
> One last nit, and this doesn't need re-review (from me):  Please use 
> the macro right_n_bits instead of a C expression (1 << x)-1, if 
> possible.  There are lots of ways that the hand-written C expression 
> can go wrong, and the macro is safer.  One more quote from the style 
> guide:
>> • Use functions from globalDefinitions.hpp when performing bitwise 
>> operations on integers. Do not code directly as C operators, unless 
>> they are extremely 
>> simple. (Examples: round_to, is_power_of_2, exact_log2.)

I changed the code to use the right_n_bits() and the nth_bit() macros 
wherever it makes sense.

Here is the new webrev: http://cr.openjdk.java.net/~zmajo/8059606/webrev.04/

The webrev link is the same as the one in my latest reply to Vladimir.

Thank you for the review!

Best regards,


> — John

More information about the hotspot-compiler-dev mailing list