RFR(S): 8042997: Make intrinsic some or all check index/range methods

Aleksey Shipilev aleksey.shipilev at oracle.com
Mon Nov 9 11:42:10 UTC 2015

Hi Roland,

Looks good. Comments:

On 11/09/2015 02:24 PM, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/8042997/webrev.00/ 

I wonder if we should avoid adding new (especially develop!) flags like
InlineObjectsCheckIndex, when -XX:DisableIntrinsic works in product bits?

> http://cr.openjdk.java.net/~roland/8042997.jdk/webrev.00/

A good practice seems to be adding the @implNote tag for the comments
like that. See e.g. String.COMPACT_STRINGS field.

> I’m not sure if we want to leave the comment on c2 in the library
> code.

We shouldn't. Instead, say "optimizing compilers".


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151109/f1dcae7e/signature.asc>

More information about the hotspot-compiler-dev mailing list