RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

Paul Sandoz paul.sandoz at oracle.com
Fri Nov 27 09:06:29 UTC 2015

> On 27 Nov 2015, at 01:59, David Holmes <david.holmes at oracle.com> wrote:
> Hi Paul,
> On 26/11/2015 7:55 PM, Paul Sandoz wrote:
>> Hi,
>> This is a request for an optimistic review to fork the sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables so that we can evolve the latter e.g. for VarHandles unsafe work
>>   http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/
>>   http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/
> Code changes seem fine.


> Tests .... don't think we use testng with any hotspot tests so not sure about that part.

There are already quite a few, primarily in the serviceability area, search for “testng”.

> Also wondering how these tests will access jdk.internal once we're using the modular image?

I believe it is sufficient to include:

  28  * @modules java.base/jdk.internal.misc


  28  * @modules java.base/sun.misc

We will need to update all tests depending on sun.misc.Unsafe when it moves to a separate module.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151127/ed9af4ae/signature.asc>

More information about the hotspot-compiler-dev mailing list