RFR(M): 8139040: Fix initializations before ShouldNotReachHere()

Coleen Phillimore coleen.phillimore at oracle.com
Mon Oct 12 18:03:03 UTC 2015

Hi, There are surprisingly few changes to runtime code for this, which 
look fine.  I'm adding the compiler alias though.


On 10/7/15 9:22 AM, Lindenmaier, Goetz wrote:
> Hi,
> SAP requires us to fix a row of issues in the hotspot coding.  I would like
> to share these with openJDK.
> This webrev fixes a row of missing intializations, mostly combined with ShouldNotReachHere()
> in default cases of switches or the like.
> http://cr.openjdk.java.net/~goetz/webrevs/8139040-init/webrev.00/
> In the debug build, ShouldNotReachHere() can be suppressed, so the uninitialized value actually can cause problems.
> In opt builds, not all tools recognize the ShouldNotReachHere properly.
> In addition to this I would like to add -Wuninitialized to the warning flags.
> This finds most of these issues in the opt build and
> would require an additional 70 fixes plus fixes in jvmtiEnter.xsl.
> Would it be appreciated to set this flag?
> Best regards,
>    Goetz.

More information about the hotspot-compiler-dev mailing list