RFR(L): 8066153: JEP-JDK-8046155: Test task: cover existing

Pavel Punegov pavel.punegov at oracle.com
Tue Oct 13 16:44:42 UTC 2015

Hi all,

please review a new version of tests:

Most changes were made to Scenario and DirectiveBuilder classes to 
reflect recent changes made by Nils.
VM fails with error message if user supplied incorrect directive, so 
Scenario was changed to handle both correct and incorrect directives.

Multiple refactoring and cleaning were also made to the code:
- Move directive file writing from the DirectiveBuilder into the new 
class DirectiveWriter.
- Add random generators for CompileCommand and methods
- All scenario related enums are moved to Scenario.
- Cleaned code in directive building.

On 08.10.2015 04:32, Vladimir Kozlov wrote:
> Got it. Okay then.
> Thanks,
> Vladimir
> On 10/8/15 2:49 AM, Pavel Punegov wrote:
>> Thank you, Vladimir.
>> LogCompilation output processing will signal failure only if we found
>> that the method was printed when it should not be.
>> It won't fail if there are no methods that should be printed at all, or
>> there is a broken output that just wouldn't match regexps.
>> On 07.10.2015 05:50, Vladimir Kozlov wrote:
>>> We have test problems with parsing output of LogCompilation and other
>>> outputs because it could be cut off. I would prefer adding new WB
>>> events API to record interesting events.
>>> Otherwise seems fine. Nils should look on this to make sure all
>>> paths/flags are tested.
>>> Thanks,
>>> Vladimir
>>> On 9/28/15 8:32 PM, Pavel Punegov wrote:
>>>> Hi,
>>>> please review the following tests fro JEP 165 Compiler Control.
>>>> These tests cover both CompileCommand and new directives (through
>>>> CompileDirectivesFile).
>>>> The main idea of tests is to create a one or multiple commands or
>>>> directives for methods in the pool and execute a test VM with a set of
>>>> method states (should method be compiled, inlined, printed, etc.). On
>>>> the end test checks that only correct methods are logged with
>>>> LogCompilation, or printed via PrintAssembly.
>>>> Bugs:
>>>> https://bugs.openjdk.java.net/browse/JDK-8066153
>>>> https://bugs.openjdk.java.net/browse/JDK-8066165
>>>> webrev: http://cr.openjdk.java.net/~ppunegov/8066153/webrev.00/

Pavel Punegov

More information about the hotspot-compiler-dev mailing list