RFR (S) 8140483: Atomic*FieldUpdaters final fields should be trusted

Aleksey Shipilev aleksey.shipilev at oracle.com
Thu Oct 29 11:09:50 UTC 2015

On 10/29/2015 12:19 AM, John Rose wrote:
> On Oct 27, 2015, at 4:19 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>> I'd like to start a formal review for the change:
>>   https://bugs.openjdk.java.net/browse/JDK-8140483
>> The feedback was overwhelmingly positive so far. Some suggested we use
>> compiler control and/or maintain the list of trusted classes. I still
>> think it is an overkill for the fix at hand, and we should instead wait
>> for the wholesale final field optimizations.
> This is a good point-fix for a specific problem with a specific set of performance-sensitive classes.
> I prefer class-based exceptions (b), as more accurate and less likely
> to be subverted by "surprising" package additions.  (The check for
> Serializable, does, however, cut out the main "surprise" effect.)

Excellent, thanks John!
Vladimir I. had also reviewed internally.

This is the changeset we will be pushing then:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151029/4b06b16d/signature.asc>

More information about the hotspot-compiler-dev mailing list