RFR(M): 8135068: Extract methodmatchers from CompilerOracle

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Sep 11 04:59:59 UTC 2015

compileBroker.cpp: should be CompileCommand (no 'r'):

"excluded by CompilerCommand"

matchesMethodMatcher name does not sound good, you don't need to include 
Class name into name. Simple use matchMethod().

I agree with Roland that you should not include 8081387 in these changes.


On 9/7/15 5:58 AM, Nils Eliasson wrote:
> Hi all,
> This is another preparatory change for compiler control. This change
> extracts the code for matching methods in CompilerOracle into a separate
> class that has subtypes for basic and typed matchers. (In a future
> change an additional subtype will show up.) The code is mostly the same
> but include fixes for error handling and pattern validation.
> A whitebox method and a test (MethodMatcherTest.java) is supplied for
> ensuring correctness of the rewrite.
> This change fixes the following bugs:
> https://bugs.openjdk.java.net/browse/JDK-8074095 - Method validation in
> CompileCommand
> https://bugs.openjdk.java.net/browse/JDK-8081387 - C2 does not respect
> exclu de command for inlining
> https://bugs.openjdk.java.net/browse/JDK-8069173 - CompileCommand needs
> better test coverage
> This patch may have to applied on top of
> http://cr.openjdk.java.net/~neliasso/8135067 Preparatory refactorings
> for compiler control to apply cleanly.
> bug: https://bugs.openjdk.java.net/browse/JDK-8135068
> webrev hotspot: http://c.openjdk.java.net/~neliasso/8135068/webrev.04
> webrev jdk: http://c.openjdk.java.net/~neliasso/8135068/webrev_jdk.01
> The change passes regular hotspot testing.
> Thanks,
> Nils

More information about the hotspot-compiler-dev mailing list