[9] RFR(S): 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes

Aleksey Shipilev aleksey.shipilev at oracle.com
Fri Sep 18 10:38:45 UTC 2015


On 09/18/2015 12:57 PM, Tobias Hartmann wrote:
> https://bugs.openjdk.java.net/browse/JDK-8136469
> http://cr.openjdk.java.net/~thartmann/8136469/webrev.00/

Fix itself looks good to me, but why don't we add a proper
PrintOptimizeStringConcat debug block instead of the assert?

I think OptoStringConcat should fail gracefully on graph mismatch
anyway, not crash the fastdebug build. Is it possible to have anything
else besides Bool or Con as an input for If?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150918/60e2ebe6/signature.asc>

More information about the hotspot-compiler-dev mailing list