RFR(S): 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
tobias.hartmann at oracle.com
Fri Sep 18 11:15:39 UTC 2015
Thanks, Aleksey. Let's see what others think.
On 18.09.2015 13:06, Aleksey Shipilev wrote:
> On 09/18/2015 02:00 PM, Tobias Hartmann wrote:
>> On 18.09.2015 12:38, Aleksey Shipilev wrote:
>>> On 09/18/2015 12:57 PM, Tobias Hartmann wrote:
>>> I think OptoStringConcat should fail gracefully on graph mismatch
>>> anyway, not crash the fastdebug build. Is it possible to have anything
>>> else besides Bool or Con as an input for If?
>> IfNode::Ideal() suggests that we could also have TOP but I don't think this should be possible right after parsing.
> Understood. Well then, assert is also plausible then, since it asserts
> the structural property of the Ideal itself, not the the subset of
> accepted shapes. Your choice, really.
>> To be save, we can also go with this fix:
> +1 to this one as well.
More information about the hotspot-compiler-dev