RFR(S): 8151880: EnqueueMethodForCompilationTest.java still fails to compile method

Nils Eliasson nils.eliasson at oracle.com
Tue Apr 5 13:54:44 UTC 2016

Hi Vladimir,

On 2016-04-05 00:57, Vladimir Kozlov wrote:
> 2 tests have -XX:+PrintCompilation flag added. Why you need it?

It helps a lot to have a compilation log to start with when these hard 
to reproduce failures happen. Those two tests test the compilation parts 
of the WB API.

I ran into another issue in these tests - the compile()-method in 
CompilerWhiteBoxTest is not reliable unless the invocation counter decay 
is turned off. I added a check of the UseCounterDecay-flag in that 
method so that no one will miss it by accident.

Best regards,
Nils Eliasson

> Thanks,
> Vladimir
> On 4/1/16 6:55 AM, Nils Eliasson wrote:
>> Hi all,
>> Please review this fix.
>> Summary:
>> There is a mismatch in the CompilerWhiteBox testcases between the
>> callable and the executable constructors. SimpleTestCase$Helper
>> implements all constructors and methods that are tested. However since
>> Helper is an inner class there will be an extra (javac created)
>> constructor that has the parent class as an appended argument. The
>> callable will invoke this constructor, but the executable will reference
>> the normal constructor.
>> Solution:
>> Stop have the Helper as an inner class. Rename it to
>> SimpleTestCaseHelper for some uniqueness in compiler commands and
>> directives.
>> Testing:
>> Run all hotspot/compiler/whitebox tests on all platforms, and all
>> hotspot/compiler tests on one platform.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8151880
>> Webrev: http://cr.openjdk.java.net/~neliasso/8151880/webrev.02/
>> Best regards,
>> Nils Eliasson

More information about the hotspot-compiler-dev mailing list