RFR(S) 8153115: Move private interface check to linktime
igor.veresov at oracle.com
Tue Apr 5 16:50:49 UTC 2016
Thanks for looking at it. Yes, it passes all hotspot jtreg tests.
> On Apr 5, 2016, at 9:30 AM, Lois Foltan <lois.foltan at oracle.com> wrote:
> Hi Igor,
> I know you have two reviews for this but could you hold off committing until I or Karen Kinnear have a chance to review. We both worked in this area a lot to support default methods in JDK 8. Also, have you run the hotspot/test/runtime/SelectionResolution tests on this?
> On 4/1/2016 2:28 PM, Igor Veresov wrote:
>> When invoking private interface methods with invokeinterface we throw ICCE. The check for that happens in the runtime part of the resolution, however, doing it at linktime seems like a better place, since the check doesn't depend on the receiver type. It also allows compiler interfaces that rely on linktime resolution to detect inconsistencies during parsing (see ciEnv::lookup_method() (CI) and ConstantPool.lookupMethod() (JVMCI) that are affected).
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8153115
>> Webrev: http://cr.openjdk.java.net/~iveresov/8153115/webrev.00/
More information about the hotspot-compiler-dev