RFR(S) 8153115: Move private interface check to linktime
lois.foltan at oracle.com
Tue Apr 5 17:34:15 UTC 2016
On 4/5/2016 12:50 PM, Igor Veresov wrote:
> Hi Lois,
> Thanks for looking at it. Yes, it passes all hotspot jtreg tests.
Thanks for waiting on this. A couple of comments:
- Section 6.5 Instructions for invokeinterface does indicate that a
"Linking Exceptions" the VM can throw an ICCE if the resolved method is
static or private. So I think moving this exception from runtime to
linktime is okay.
- I'm concerned about the change on line #998, #1030, #1316. I don't
think you are necessarily guaranteed to have the bytecodes that you are
now passing to resolve_interface_method. For example, line #998 within
linktime_resolve_static_method, you may not have an invokestatic here,
you may have another invoke* bytecode trying to invoke a static
interface method. Passing in Bytecodes::_invokestatic seems wrong,
because even if the resolved method is static, "nostatics" was set to false.
Just curious did you also run the testbase default methods tests?
>> On Apr 5, 2016, at 9:30 AM, Lois Foltan <lois.foltan at oracle.com> wrote:
>> Hi Igor,
>> I know you have two reviews for this but could you hold off committing until I or Karen Kinnear have a chance to review. We both worked in this area a lot to support default methods in JDK 8. Also, have you run the hotspot/test/runtime/SelectionResolution tests on this?
>> On 4/1/2016 2:28 PM, Igor Veresov wrote:
>>> When invoking private interface methods with invokeinterface we throw ICCE. The check for that happens in the runtime part of the resolution, however, doing it at linktime seems like a better place, since the check doesn't depend on the receiver type. It also allows compiler interfaces that rely on linktime resolution to detect inconsistencies during parsing (see ciEnv::lookup_method() (CI) and ConstantPool.lookupMethod() (JVMCI) that are affected).
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8153115
>>> Webrev: http://cr.openjdk.java.net/~iveresov/8153115/webrev.00/
More information about the hotspot-compiler-dev