[aarch64-port-dev ] RFR: 8153837 : aarch64: handle special cases for MaxINode & MinINode

Andrew Haley aph at redhat.com
Mon Apr 11 11:56:02 UTC 2016


On 04/11/2016 12:47 PM, Felix Yang wrote:
>     Thanks for reviewing the patch.

>     I find that the cases the patch tries to catch here are the
>     result of loop transformations.
>     And it's hard to produce a test case to for it simply using the
>     Math.min/max API.  (Seems C2 will not create a MaxINode/MinINode
>     for a call for these APIs) But I do noticed some JTReg hotspot
>     test cases that already generates the pattern.
>     So the patch got tested for the most part and is not causing us trouble.

Sure, but that doesn't necessarily give us test coverage of the
changes you've made.  Is the problem that you don't know how to write
test cases to cover your changes?


More information about the hotspot-compiler-dev mailing list