RFR(XS): 8155735: use strings instead of Symbol* in JVMCI exception stubs

Tom Rodriguez tom.rodriguez at oracle.com
Fri Apr 29 15:27:39 UTC 2016

> On Apr 29, 2016, at 6:45 AM, Roland Schatz <roland.schatz at oracle.com> wrote:
> Hi,
> Please review this small change:
> webrev: http://cr.openjdk.java.net/~rschatz/JDK-8155735/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8155735
> This makes it possible to use the exception stubs without knowing about the hotspot-only concept of symbol pointers.

I think you need to handle the case where the symbol doesn’t exist.  lookup_symbol will return NULL if there’s no currently loaded symbol with that name which will lead to a SEGV later.  So you either need to throw an exception here or you should use 

TempNewSymbol symbol = SymbolTable::new_symbol

and let new_exception throw an exception if the class named by symbol doesn’t exist.


> Thanks,
> Roland

More information about the hotspot-compiler-dev mailing list