RFR (XXS): 8144621: CompilerControl: inline tests timeout with Xcomp
vladimir.kozlov at oracle.com
Mon Feb 15 18:44:53 UTC 2016
Thank you, Pavel, now I understand the fix. Looks good.
On 2/15/16 9:43 AM, Pavel Punegov wrote:
> see inline
>> On 15 Feb 2016, at 19:41, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>> Should we fix tests with *.* commands instead?
> Most tests generate their commands with the getValidMethodDescriptor() method. This fix makes it not use *.* patterns at
> all. If we found this pattern, the method returns a plain method name.
>> Could you, please, list those tests (I want to look)?
> Closed inlining tests are also affected.
> As for PrintAssembly tests:
> but they suffer from the JDK-8140354 <https://bugs.openjdk.java.net/browse/JDK-8140354> that is also caused by *.* with
> Xcomp. I plan to rewrite OutputAnalyzer to save output on disk.
>> May be add -Xmixed if they don't like -Xcomp?
> Well, this could be a fix, but then all inlining tests would be run only with Xmixed.
>> Or use real method's names instead of *.*?
> that the fix is about.
>> On 2/15/16 8:26 AM, Pavel Punegov wrote:
>>> please review this small fix for CompilerControl tests.
>>> Issue: tests that generate commands like "inline *.*" (-XX:CompileCommand or directives) with Xcomp make compilers
>>> forcibly inline everything. This significantly increases execution time leading to timeout.
>>> Fix: don’t generated *.* patterns at all for such tests. It will also makes tests that use PrintAssembly to not fail
>>> with OOME by decreasing of the amount of output.
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8144621
>>> webrev: http://cr.openjdk.java.net/~ppunegov/8144621/webrev.00/
More information about the hotspot-compiler-dev