RFR (XXS): 8144621: CompilerControl: inline tests timeout with Xcomp
nils.eliasson at oracle.com
Tue Feb 16 17:41:53 UTC 2016
On 2016-02-15 17:41, Vladimir Kozlov wrote:
> Should we fix tests with *.* commands instead? Could you, please, list
> those tests (I want to look)? May be add -Xmixed if they don't like
> -Xcomp? Or use real method's names instead of *.*?
+1 on adding -Xmixed to all the compiler control tests. Xcomp doesn't
add any value to these tests.
Otherwise - looks good.
Thanks for fixing!
> On 2/15/16 8:26 AM, Pavel Punegov wrote:
>> please review this small fix for CompilerControl tests.
>> Issue: tests that generate commands like "inline *.*"
>> (-XX:CompileCommand or directives) with Xcomp make compilers
>> forcibly inline everything. This significantly increases execution
>> time leading to timeout.
>> Fix: don’t generated *.* patterns at all for such tests. It will also
>> makes tests that use PrintAssembly to not fail
>> with OOME by decreasing of the amount of output.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8144621
>> webrev: http://cr.openjdk.java.net/~ppunegov/8144621/webrev.00/
More information about the hotspot-compiler-dev