[8u] RFR 8130150: Implement BigInteger.montgomeryMultiply intrinsic

Doerr, Martin martin.doerr at sap.com
Wed Feb 17 10:10:44 UTC 2016


is it allowed to add a public method to MutableBigInteger in jdk8u?

I guess this will need additional approval. Alternatively, the method "static long inverseMod64(long val)" could be moved into BigInteger.java as private method.

Otherwise, the jdk8u change looks good.

Best regards,

-----Original Message-----
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Samstag, 13. Februar 2016 01:37
To: Vladimir Kempik <vladimir.kempik at oracle.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: [8u] RFR 8130150: Implement BigInteger.montgomeryMultiply intrinsic

Looks fine but you need to send this to jdk8u-dev at openjdk.java.net to 
get approval for backport.


On 2/12/16 10:31 AM, Vladimir Kempik wrote:
> Webrev for jdk part:
> http://cr.openjdk.java.net/~vkempik/8130150/webrev_jdk.00/
> On 12.02.2016 21:29, Vladimir Kempik wrote:
>> Hello
>> Please review this backport of 8130150 to jdk8u.
>> Implement BigInteger.montgomeryMultiply intrinsic
>> The patch didn't apply cleanly, some changes were needed. Most of them are just to make patch apply, except one.
>> for MACC and MACC2 defines, __asm__ were changed to asm, to make solaris compiler (SS12U1) happy.
>> The patch has two parts, for jdk and hotspot.
>> Testing: jprt, testcase.
>> Bug:https://bugs.openjdk.java.net/browse/JDK-8130150
>> Webrev:http://cr.openjdk.java.net/~vkempik/8130150/webrev_hs.00/
>> Thanks
>> -Vladimir

More information about the hotspot-compiler-dev mailing list