RFR(S): 8148159: [TESTBUG] TestCompilerDirectivesCompatibility tests fails on non-tiered server VMs
nils.eliasson at oracle.com
Mon Feb 22 09:47:59 UTC 2016
On 2016-02-17 16:52, Pavel Punegov wrote:
> Hi Nils,
> Do we need hasC1/2Compiler methods?
I wanted to know exactly what compilers I am testing.
> There is a compiler.tstlibrary.CompilerUtils class that provides tests
> with available levels.
Didn't know about that one. It fills a good purpose but it should not
guess what compiler levels are available - rather query the VM directly.
We should also move a lot of useful constants from CompilerWhiteBoxTest
> There is an example of usage
> in test/compiler/compilercontrol/share/actions/CompileAction.java.
> Also, what about JVMCI in case of hasC2Compiler? AFAIK it works with
> levels, but I don’t know if it will with such ifdef.
I only test the compilers that I know will support this flag. We would
need some additional test utils for querying what compiler uses the
> Otherwise, it looks good (not a Reviewer)
Thanks for taking a look,
>> On 16 Feb 2016, at 16:01, Nils Eliasson <nils.eliasson at oracle.com
>> <mailto:nils.eliasson at oracle.com>> wrote:
>> Please review this change.
>> The tests relied on C1 always being available and thus fails on C2
>> only server configurations. The fix adds two whitebox methods for
>> checking if C1 and C2 is available, and then tests both compilers
>> separately. Also adding Xmixed to the commandline since this test
>> doesn't need Xcomp testing.
>> Nils Eliasson
> — Thanks,
> Pavel Punegov
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev