[9] RFR(S): 8159715: Fix for 8072422 is incorrect

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Jun 17 00:52:16 UTC 2016

Thank you, Tobias

Changes look good.

Please, try to run at least jtreg tests with -XX:-UseLoopPredicate. There could be some code that assume that predicates exist only with UseLoopPredicate (missed LoopLimitCheck originally).


On 6/16/16 6:41 AM, Tobias Hartmann wrote:
> Hi,
> please review the following fix:
> https://bugs.openjdk.java.net/browse/JDK-8159715
> http://cr.openjdk.java.net/~thartmann/8159715/webrev.00/
> The fix for JDK-8072422 [1] removed the RangeLimitCheck flag that was set to true by default. In PhaseIdealLoop::do_range_check(), conditional_rc should now be always set to true. The LoopLimitCheck flag was also removed but the code in parse1.cpp and loopnode.cpp was not adapted correctly (see bug description).
> Tested with JPRT and RBT (running).
> Thanks,
> Tobias
> [1] http://cr.openjdk.java.net/~zmajo/8072422/webrev.02/

More information about the hotspot-compiler-dev mailing list