RFR: 8159613: [Findbugs] various warnings reported for JVMCI sources

Christian Thalinger cthalinger at twitter.com
Tue Jun 21 22:18:12 UTC 2016


I guess the problem in getHostArchitectureName is the missing default case?  I’d prefer something like this:

-        switch (arch) {
-            case "x86_64":
                return "amd64";
-            case "sparcv9":
                 return "sparc";
                 return arch;

> On Jun 20, 2016, at 1:00 PM, Doug Simon <doug.simon at oracle.com> wrote:
> Please review this webrev which addresses all the issues[1] identified by FindBugs in the JVMCI Java code. A significant number of issues related to exposing array fields. For example:
> M V EI: jdk.vm.ci.hotspot.sparc.SPARCHotSpotRegisterConfig.getCallerSaveRegisters() may expose internal representation by returning SPARCHotSpotRegisterConfig.callerSaveRegisters  At SPARCHotSpotRegisterConfig.java:[line 187]
> M V EI: jdk.vm.ci.amd64.AMD64.getAvailableValueRegisters() may expose internal representation by returning AMD64.valueRegistersSSE  At AMD64.java:[line 252]
> These have been addressed by either creating an immutable array wrapper classes (e.g. RegisterArray) or by documenting intentional mutability and applying @SuppressFBWarnings where necessary.
> https://bugs.openjdk.java.net/browse/JDK-8159613
> http://cr.openjdk.java.net/~dnsimon/8159613/
> -Doug
> [1] http://cr.openjdk.java.net/~dnsimon/8159613/FindBugsIssues.txt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160621/bfda5655/attachment.html>

More information about the hotspot-compiler-dev mailing list