RFR(S): 8147844: new method j.l.Runtime.onSpinWait() and the corresponding x86 hotspot instrinsic
vitalyd at gmail.com
Thu Mar 10 02:08:57 UTC 2016
On Wednesday, March 9, 2016, Ivan Krylov <ivan at azulsystems.com> wrote:
> Merely for consistency with the surrounding code. I wouldn't write it that
> way but I have to follow the practice there.
I looked just above the lines you added and there's a supports_cx8 check
using the ! form. But you're right, your form appears elsewhere too in the
> Thanks, Igor! I will ask someone to push the change in once the JEP
> becomes targeted.
> On 09/03/2016 17:39, Vitaly Davidovich wrote:
> Minor quibble - in x86.ad:
> if (VM_Version::supports_on_spin_wait() == false)
> Any particular reason it's using == false form instead of
> On Wednesday, March 9, 2016, Ivan Krylov <
>> Paul, Indeed, thanks. I have modified the test.
>> I also made changes to reflect the fact that onSpinWait is now decided to
>> be placed into j.l.Thread.
>> This is a new webrev: http://cr.openjdk.java.net/~ikrylov/8147844.hs.04/
>> This is the diff between previous and this patches (03 vs 04):
>> On 12/02/2016 06:01, Paul Sandoz wrote:
>>> On 12 Feb 2016, at 00:55, Ivan Krylov <ivan at azulsystems.com
>>>> Hi Igor,
>>>> Thanks both for your help and your reviews.
>>>> Here is a new version, tested on mac for c1 and c2:
>>>> Now that support C1 is supported should the test be updated with C1
>>> only execution?
> Sent from my phone
Sent from my phone
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev