RFR(S): 8147844: new method j.l.Runtime.onSpinWait() and the corresponding x86 hotspot instrinsic

Paul Sandoz paul.sandoz at oracle.com
Thu Mar 10 17:45:08 UTC 2016

> On 10 Mar 2016, at 03:05, Ivan Krylov <ivan at azulsystems.com> wrote:
> Merely for consistency with the surrounding code. I wouldn't write it that way but I have to follow the practice there.
> See http://hg.openjdk.java.net/jdk9/jdk9/hotspot/file/7e7e50ac4faf/src/cpu/x86/vm/x86.ad <http://hg.openjdk.java.net/jdk9/jdk9/hotspot/file/7e7e50ac4faf/src/cpu/x86/vm/x86.ad>
> Thanks, Igor! I will ask someone to push the change in once the JEP becomes targeted.

Because there is also an API change associated with this we have to go through an internal process (referred to as CCC) to track the API change and review the compatibility/design. It should just be a formality for this API.

If you are happy with:

http://cr.openjdk.java.net/~ikrylov/8147844.jdk.03/src/java.base/share/classes/java/lang/Thread.java.sdiff.html <http://cr.openjdk.java.net/~ikrylov/8147844.jdk.03/src/java.base/share/classes/java/lang/Thread.java.sdiff.html>

i can do this tomorrow, but i have one suggestion: use @apiNote for the example (i know i am hi-jacking this thread here and not using the core-libs thread, but it’s just too convenient to write this here!).

Once approved we can then push all changes to hs-comp.

> Ivan
> On 09/03/2016 17:39, Vitaly Davidovich wrote:
>> Minor quibble - in x86.ad <http://x86.ad/>:
>> if (VM_Version::supports_on_spin_wait() == false)
>> Any particular reason it's using == false form instead of !supports_on_spin_wait?
>> On Wednesday, March 9, 2016, Ivan Krylov < <mailto:ivan at azulsystems.com>ivan at azulsystems.com <mailto:ivan at azulsystems.com>> wrote:
>> Paul, Indeed, thanks. I have modified the test.

Ok, looks good.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160310/db98f5eb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160310/db98f5eb/signature.asc>

More information about the hotspot-compiler-dev mailing list