RFR(S): 8144693: Intrinsify StringCoding.hasNegatives() on SPARC
vladimir.kozlov at oracle.com
Thu Mar 17 20:12:00 UTC 2016
What do you think, Guy?
Will you prepare another webrev or we can proceed with your latest webrev?
On 3/15/16 6:00 PM, John Rose wrote:
> On Mar 15, 2016, at 8:53 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>> Somehow I missed this mail.
>> Changes looks good now.
> Small nit: The first sra instruction doesn't add any value. The andcc(inp, 0x7, i) zeroes all high bits above 0x7, and the neg(i, t3) fills them with ones. Thus sra(t3, 0, t4) is a simple copy from
> t3 to t4.
> (I suspect there may be other looseness in the fragment processing parts, but I haven't looked at it closely.)
> Overall, nicely done.
> — John
More information about the hotspot-compiler-dev