[9] RFR JDK-8152344: JVMCI test task: Unit tests for ConstantReflectionProvider

Christian Thalinger christian.thalinger at oracle.com
Mon Mar 21 21:20:45 UTC 2016

Sorry but I have to bring this up again… there is so much line-breaking going on it’s ridiculous.  Especially in:


Or this:
 118         Assert.assertEquals(CONSTANT_REFLECTION_PROVIDER.readStableFieldValue(field,
 119                                                                               receiver,
 120                                                                               isDefStab),
 121                 expected, "Unexpected result:");

Here is a suggestion.  Move your tests into the package jdk.vm.ci.hotspot.test under:


Look at jdk.vm.ci.runtime.test as an example.  Then we add jdk.vm.ci.hotspot.test to the mx configuration file and let the predefined formatting rules take care of it.

This would be my preferred way because then the tests are automatically imported into IDEs as well.  Actually all JVMCI tests should do it this way.

> On Mar 21, 2016, at 11:07 AM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
> Hello
> Please review some new unit tests for methods of JVMCI jdk.vm.ci.hotspot.HotSpotConstantReflectionProvider class.
> The tests cover most public methods of the class named above.
> Here "test/compiler/jvmci/constantReflectionProviderTest/HotSpotConstantReflectionProviderTest.java" is the JTREG-testng file, all other classes are testng data providers, except TestHelper.java and DummyClass.java that store all necessary variables.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8152344
> Webrev: http://cr.openjdk.java.net/~kshefov/8152344/webrev.00/
> Thanks
> -Konstantin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160321/a92e64e1/attachment-0001.html>

More information about the hotspot-compiler-dev mailing list