RFR(S) : 8152636 : TestHasNegatives.java fails after Jigsaw changes were integrated
igor.ignatyev at oracle.com
Tue Mar 29 21:09:21 UTC 2016
Vladimir, thank you for the review!
> On Mar 30, 2016, at 12:00 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> Looks fine.
> On 3/29/16 1:53 PM, Igor Ignatyev wrote:
>>> 46 lines changed: 39 ins; 2 del; 5 mod;
>> Hi all,
>> could you please review this tiny fix which updates TestHasNegatives.java to work in jigsaw-world?
>> the test needs access to package-private class (j.l.StringCoding), j.l.Helper class is introduced to provide that access. j.l.Helper is built as patch for ‘java.base' module.
>> testing: locally + w/ -XX:+PrintInlining to check that j.l.StringCoding::hasNegatives is intrinsified
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8152636
>> — Igor
More information about the hotspot-compiler-dev