RFR(S): 8150921: Update Unsafe getters/setters to use double-register variants

Mikael Vidstedt mikael.vidstedt at oracle.com
Tue May 3 21:59:17 UTC 2016

On 5/3/2016 1:33 PM, Aleksey Shipilev wrote:
> On 05/03/2016 11:17 PM, Mikael Vidstedt wrote:
>> On 5/3/2016 1:05 PM, Aleksey Shipilev wrote:
>>> I actually wonder why those accessors (especially non-long) are
>>> UNSAFE_ENTRY, not UNSAFE_LEAF, if "we can treat those as leaf
>>> routines"...
>> Ah, yes, now I see what you're saying. In general, since the mutex isn't
>> actually checking for safepoints right now this isn't really a problem,
>> but it would definitely be nice to unify it. How about I file a separate
>> enhancement for moving the other memory operations into MemoryAccess?
> Sure, do that. That's not the end of unsafe.cpp story anyway.

We all wish it would be the end of the story, don't we... ;)

I filed https://bugs.openjdk.java.net/browse/JDK-8155982 - 
"CompareAndExchange/Swap should leverage MemoryAccess class


> Thanks,
> -Aleksey

More information about the hotspot-compiler-dev mailing list