RFR: 8155023: jdk.vm.ci needs to securely export services
Alan.Bateman at oracle.com
Thu May 5 14:55:54 UTC 2016
On 03/05/2016 14:34, Doug Simon wrote:
I skimmed through this.
The module-info.java looks okay. The permission check idiom in
JVMCICompilerFactory (and EventProvider) look fine.
I'm not sure about using RuntimePermission("jvmci"). One reason is that
RuntimePermission specifies in its javadoc all the possible targets. It
might be better to just introduce a new basic permission for this.
One thing about Services.load is that it uses ServiceLoader.load and
hence the TCCL. I don't know if this is what you here, I suspect you
want the system class loader.
In passing, the @return for getTrivialPrefixes() suggests an empty array
can be returned and so I assume the default should be to return an empty
array rather than null.
More information about the hotspot-compiler-dev