RFR(M): 8154826: AArch64: take better advantage of base + shifted offset addressing mode

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri May 6 16:01:34 UTC 2016

Yes, looks good. Closed changes will be simple now :)

Roland, are you on hotspot-compiler-dev at openjdk.java.net list? Or I should CC to you for reviews?


On 5/6/16 3:18 AM, Roland Westrelin wrote:
> Thanks for looking at this, Vladimir.
>> You did not remove Matcher::clone_shift_expressions variable
>> initialization from all .ad files.
>> Changes look correct - you cloned shared code into .ad files and make
>> code platform specific.
>> But duplicated code will increase maintenance cost. Can you leave code
>> for clone_shift_expressions=false case (same code on several platforms)
>> in matcher.cpp?
> What about this?
> http://cr.openjdk.java.net/~roland/8154826/webrev.02/
> Roland.

More information about the hotspot-compiler-dev mailing list