8144856 : fix assert in CompiledStaticCall::set_to_interpreted

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon May 9 08:52:01 UTC 2016

Hi Jamsheed,

Do you want to avoid that data/destination are changed concurrently
between the two compares? Or do you just want to save costs of the call?

To assure the first, you need to make the two local variables volatile.
Else the compilers can add reloads after inlining data() and jump_destination().
We observed this with the Visual Studio compiler and xlC on aix.

Besides that the change looks good.

Best regards,

> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Jamsheed C m
> Sent: Freitag, 6. Mai 2016 13:21
> To: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
> Subject: RFR: 8144856 : fix assert in CompiledStaticCall::set_to_interpreted
> Hi,
> Request for review for an assert cleanup change.
> bug id : https://bugs.openjdk.java.net/browse/JDK-8144856
> webrev: http://cr.openjdk.java.net/~jcm/8144856/webrev.00/
> Best Regards,
> Jamsheed

More information about the hotspot-compiler-dev mailing list