RFR(S): 8149463 - [jittester] rarely generates tests with compile error

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon May 9 22:16:05 UTC 2016

Seems fine.


On 5/6/16 7:59 AM, Dmitrij Pochepko wrote:
> Hi,
> please review fix for 8149463 - [jittester] rarely generates tests with
> compile error
> A reason for incorrect code generation was "removeSelf" method, which is
> called when IR tree is cut to meet constraints. This method is
> implemented in all loops to not remove node loop completely, but leave
> some of node content instead("header" and "initialization". In this
> specific order.) So, incorrect code was generated in case header code
> used some variable declared in initialization block, thus, leading to
> variable usage before declaration. So, this patch fixes this problem.
> Also, minor code improvement: instead of removing self(loop node), it's
> overwritten with "initialization" block and then a header content is added.
> webrev: http://cr.openjdk.java.net/~dpochepk/8149463/webrev.01/
> CR: https://bugs.openjdk.java.net/browse/JDK-8149463
> I've tested this fix using linux_x64.
> Thanks,
> Dmitrij

More information about the hotspot-compiler-dev mailing list