RFR: 8152341 - JVMCI test task: Unit tests for MemoryAccessProvider

Dmitrij Pochepko dmitrij.pochepko at oracle.com
Tue May 10 14:33:24 UTC 2016


Yes. I was using netbeans. I've applied eclipse formatter, then run mx 
checkstyle and fixed all warnings except " '.' is preceded with 
whitespace". Fixing this warning will make huge lines.

Please take a look at v02.


>> On May 6, 2016, at 4:38 AM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
>> Hi,
>> please review patch for 8152341 - JVMCI test task: Unit tests for MemoryAccessProvider
>> A new tests were added for MemoryAccessProvider implementation. This patch contains tests for all MemoryAccessProvider methods (mostly a positive and few negative tests per method). A testng framework is used.
>> webrev: http://cr.openjdk.java.net/~dpochepk/8152341/webrev.01/
> These two files don’t look like they have been formatted properly.  Did you use an IDE to edit these?
>> CR: https://bugs.openjdk.java.net/browse/JDK-8152341
>> I've tested it on linux_x64
>> Thanks,
>> Dmitrij

More information about the hotspot-compiler-dev mailing list