RFR: 8152341 - JVMCI test task: Unit tests for MemoryAccessProvider
doug.simon at oracle.com
Tue May 10 15:49:30 UTC 2016
> On 10 May 2016, at 16:33, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
> Yes. I was using netbeans. I've applied eclipse formatter, then run mx checkstyle and fixed all warnings except " '.' is preceded with whitespace". Fixing this warning will make huge lines.
You can disable the formatter with:
code that won’t be formatted
However, the lines don’t look so long to me - maybe you need to get a larger monitor ;-)
>>> On May 6, 2016, at 4:38 AM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
>>> please review patch for 8152341 - JVMCI test task: Unit tests for MemoryAccessProvider
>>> A new tests were added for MemoryAccessProvider implementation. This patch contains tests for all MemoryAccessProvider methods (mostly a positive and few negative tests per method). A testng framework is used.
>>> webrev: http://cr.openjdk.java.net/~dpochepk/8152341/webrev.01/
>> These two files don’t look like they have been formatted properly. Did you use an IDE to edit these?
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8152341
>>> I've tested it on linux_x64
More information about the hotspot-compiler-dev