RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot
igor.ignatyev at oracle.com
Wed Aug 2 17:53:52 UTC 2017
thank you for your review. Although abbreviations should not be upper-cased in method names, I've renamed vmAot to vmAOT to be consistent w/ the rest of the class.
> On Aug 2, 2017, at 5:49 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
> Hi Igor,
> the change is looking good.
> A small thing, I would spell vmAot() as vmAOT(), all abbreviations
> (except for Jvmci) are capitalized here.
> It passed the tests on all platforms that have been running so far.
> (Some had an unrelated issue tonight).
> Best regards,
>> -----Original Message-----
>> From: Igor Ignatyev [mailto:igor.ignatyev at oracle.com]
>> Sent: Dienstag, 1. August 2017 17:51
>> To: hotspot-compiler-dev at openjdk.java.net compiler <hotspot-compiler-
>> dev at openjdk.java.net>
>> Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
>> Subject: RFR(S) : 8185536 : @key aot should be replaced w/ @requires
>>> 81 lines changed: 19 ins; 0 del; 62 mod
>> Hi all,
>> could you please review this small patch which introduces 'vm.aot' property
>> into jtreg @requires context and replaces all '@key aot' added by 8185046
>> w/ '@requiers vm.aot'?
>> Goetz(author of 8185046) is checking that it works for their configurations.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8185536
>> testing: hotspot/test/compiler/aot tests
>> - on linux-x64 : 56 tests selected/run
>> - on linux-x86 : 0 tests selected/run
>> - on windows-x64 (after remove tests from problemlist) : 56 tests
>> - on windows-x86 (after remove tests from problemlist) : 0 tests
>>  https://bugs.openjdk.java.net/browse/JDK-8185046
>> -- Igor
More information about the hotspot-compiler-dev