RFR: JDK-8186115 - libelf still referenced after 8172670
vladimir.kozlov at oracle.com
Mon Aug 21 15:29:39 UTC 2017
On 8/21/17 7:05 AM, Bob Vandette wrote:
> No, I have not pushed this fix yet. I was waiting for you to look into the CodeSectionProcessor issue.
Leave CodeSectionProcessor.java as it is - don't even change comment. I
will update it if needed. No updated webrev needed.
> Do you want me to just push it?
Yes. I saw Erik reviewed build change.
> Can you send me a diff of the change you want me to add?
Ignore my comment. jdk.tools.jaotc.test has already recorded in
suite.py. I missed it first.
Your change to suite.py is good.
>> On Aug 19, 2017, at 3:46 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> Bob, did you pushed it?
>> If not yes, please fix .mx.graal/suite.py for unit tests Rickard added. They have dependency on jdk.tools.jaotc.collect:
>> They failed when I modified collect and other classes. We need to have dependency on it in suite.py.
>> On 8/15/17 12:10 PM, Vladimir Kozlov wrote:
>>> On 8/15/17 11:55 AM, Bob Vandette wrote:
>>>> Please review these changes for JDK 10 that remove all dependencies on libelf from the JDK
>>>> build system.
>>>> Compiler team: Please check CodeSectionProcessor. Is the stepping through all
>>>> foreign call still necessary? I only removed the comment.
>>> I will look. It could be the problem was not libelf but loader.
More information about the hotspot-compiler-dev