RFR(L): 8185979: PPC64: Implement SHA2 intrinsic
martin.doerr at sap.com
Thu Aug 24 15:02:06 UTC 2017
thank you for providing SHA2 acceleration. It basically looks good. I have also checked that it doesn't break the AIX build.
But I have very few change requests.
- The file name of the new file should end with _ppc.cpp.
- "this->" should be removed from branch instructions: this->b
- Why are you using Register references "const Register&"? That's not common.
- It would be nice to have Big Endian support if it doesn't take much effort. (I can assist with testing.)
Note: This change contains test changes, so a sponsor from Oracle is needed.
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Gustavo Serra Scalet
Sent: Donnerstag, 17. August 2017 21:06
To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>
Cc: ppc-aix-port-dev at openjdk.java.net
Subject:  RFR(L): 8185979: PPC64: Implement SHA2 intrinsic
Could you please review this specific PPC64 change to hotspot? By implementing this intrinsic I noticed a significant improvement when using SHA-2 (e.g: Sample run reduced 6.5s run to 2.8s for SHA256.)
Gustavo Serra Scalet
More information about the hotspot-compiler-dev