RFR(XS): 8180473: Use proper deallocation for FileBuff::_bigbuf
thomas.stuefe at gmail.com
Thu May 18 18:47:39 UTC 2017
looks good. Old code may have worked but relied on undefined behaviour.
Kind Regards, Thomas
On Wed, May 17, 2017 at 12:52 PM, Zoltán Majó <zoltan.majo at oracle.com>
> please review the following fix for 8180473.
> It is a good coding practice to properly deallocate dynamically allocated
> resources. In particular, dynamically allocated memory for arrays using the
> array-specific new operator is supposed to be deallocated using the
> array-specific delete operator. The deallocation of FileBuff::_bigbuf
> does not follow this recommendation and should therefore be changed. Tested
> with JPRT.
> Thank you!
> Best regards,
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev