RFR(XS): 8180473: Use proper deallocation for FileBuff::_bigbuf
zoltan.majo at oracle.com
Fri May 19 08:41:53 UTC 2017
On 05/18/2017 08:47 PM, Thomas Stüfe wrote:
> Hi Zoltan,
> looks good. Old code may have worked but relied on undefined behaviour.
thank you for the review.
Unfortunately, the fix was already in the repo when your mail arrived,
so I am not able to mention you as a reviewer. Sorry for that.
> Kind Regards, Thomas
> On Wed, May 17, 2017 at 12:52 PM, Zoltán Majó <zoltan.majo at oracle.com
> <mailto:zoltan.majo at oracle.com>> wrote:
> please review the following fix for 8180473.
> It is a good coding practice to properly deallocate dynamically
> allocated resources. In particular, dynamically allocated memory
> for arrays using the array-specific new operator is supposed to
> be deallocated using the array-specific delete operator. The
> deallocation of FileBuff::_bigbuf does not follow this
> recommendation and should therefore be changed. Tested with JPRT.
> Thank you!
> Best regards,
More information about the hotspot-compiler-dev