RFR (S): 8180755: Remove use of bitMap.inline.hpp include from instanceKlass.hpp and c1_ValueSet.hpp

David Holmes david.holmes at oracle.com
Tue May 23 01:38:14 UTC 2017

Hi Thomas,

This looks okay to me. A couple of comments:


inline void GenerateOopMap::set_bbmark_bit(int bci) {
   _bb_hdr_bits.at_put(bci, true);

Does "inline" serve any purpose here?



-  void          set_bbmark_bit              (int bci) {
-    _bb_hdr_bits.at_put(bci, true);
-  }
+  inline void   set_bbmark_bit              (int bci);
    void          clear_bbmark_bit            (int bci) {
      _bb_hdr_bits.at_put(bci, false);

I don't understand why set_bbmark_bit had to be moved out but 
clear_bbmark_bit remains ??

On 23/05/2017 1:39 AM, Thomas Schatzl wrote:
> Hi all,
>    can I have reviews for this change that removes the use of
> bitMap.inline.hpp from instanceKlass.hpp (which does not use bitMaps at
> all) and c1_ValueSet.hpp as per guidelines?
> This is only seemingly a large change the reason is the required move
> of methods that use the BitMap class in .hpp files into .inline.hpp
> files (GC and compiler only).
> Also, this touches files from GC, runtime and compiler, so I sent this
> RFR to all corresponding lists to get reviews from every group for
> their respective files. It's mostly GC changes though.
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8180755
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8180755/webrev/
> Testing:
> jprt
> Thanks,
>    Thomas

More information about the hotspot-compiler-dev mailing list