RFR (S): 8145728 compiler/cpuflags/TestAESIntrinsicsOnSupportedConfig.java fails in some configurations
ekaterina.pavlova at oracle.com
Fri May 26 00:49:45 UTC 2017
It is not needed, removed.
Thanks for catching this. I have uploaded new webrev.
On 5/25/17 5:18 PM, Vladimir Kozlov wrote:
> Looks good to me. Thank you for fixing it.
> One question: why CPUInfo needs to be imported?
> On 5/25/17 4:07 PM, Ekaterina Pavlova wrote:
>> Hi all,
>> Please review the fix for compiler/cpuflags/TestAESIntrinsicsOnSupportedConfig.java.
>> The testcase 'testUseAES' fails in case the test is ran in server configuration where -XX:TieredStopAtLevel is set to 1,2 or 3.
>> Added TieredStopAtLevel check.
>> Also got rid of AESSupportPredicate and use "@requires" instead.
>> This is more efficient as in this case the tests will be skipped if pre-conditions are not valid.
>> Such tests should be also reported as "not run" instead of "passed" which is more accurate.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8145728
>> webrev: http://cr.openjdk.java.net/~epavlova//8145728/webrev.00/
>> Tested by running jprt and manually running compiler/cpuflags tests with different -XX:TieredStopAtLevel values.
>> Igor Ignatyev volunteered to sponsor this change.
More information about the hotspot-compiler-dev