RFR(S): 8190781: ppc64 + s390: Fix CriticalJNINatives
martin.doerr at sap.com
Mon Nov 6 17:19:01 UTC 2017
thanks for the review. Pushed with improved comments.
New tests were just pushed today, so it's good to have this one in, which is needed to get them working correctly.
From: Lindenmaier, Goetz
Sent: Montag, 6. November 2017 11:54
To: Doerr, Martin <martin.doerr at sap.com>; 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>
Subject: RE: RFR(S): 8190781: ppc64 + s390: Fix CriticalJNINatives
looks good, but please fix this comment to something meaningful before pushing:
(at least I don't grok it :))
// Value is in an input register pass we must flush it to the stack
> -----Original Message-----
> From: Doerr, Martin
> Sent: Montag, 6. November 2017 11:49
> To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-
> dev at openjdk.java.net>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Subject: RFR(S): 8190781: ppc64 + s390: Fix CriticalJNINatives
> CriticalJNINatives are currently not working correctly on PPC64 and s390.
> Code which saves & restores int type values is missing.
> The s390 implementation needs 2 more minor fixes. Please see my webrev:
> I've also fixed an obvious copy&paste bug in PPC64 assembler in a currently
> unused instruction.
> My proposed change also switches off SuperwordUseVSX on PPC64 as
> discussed with Michihiro who is still working on it.
> Please review.
> Best regards,
More information about the hotspot-compiler-dev