[10] RFR(S): 8179026: Remove explicit code cache options processing

Tobias Hartmann tobias.hartmann at oracle.com
Wed Nov 22 07:05:24 UTC 2017

Hi Vladimir,

thanks for the review!

On 21.11.2017 21:43, Vladimir Kozlov wrote:
> Looks good. Can you also print size_initial in error message in codeCache.cpp?

Sure, here's the updated webrev:

Best regards,
> On 11/20/17 12:22 AM, Tobias Hartmann wrote:
>> Hi,
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8179026
>> http://cr.openjdk.java.net/~thartmann/8179026/webrev.00/
>> I've removed the explicit processing of -XX:CodeCacheExpansionSize, -XX:NonNMethodCodeHeapSize, -XX:ProfiledCodeHeapSize
>> and -XX:NonProfiledCodeHeapSize because generic option processing already supports memory values. I've also added a
>> lower bound of vm_page_size() to all of them except the non-profiled and the profiled size because these can be 0. The
>> actual checking is done in codeCache.cpp.
>> All tests pass.
>> Thanks,
>> Tobias

More information about the hotspot-compiler-dev mailing list