RFR: 8191813: compiler/runtime/SpreadNullArg.java fails in tier1
rahul.v.raghavan at oracle.com
Sun Nov 26 17:09:36 UTC 2017
Thank you Dan for the review.
On Friday 24 November 2017 08:56 PM, Daniel D. Daugherty wrote:
> On 11/24/17 6:16 AM, Rahul Raghavan wrote:
>> Please review the following fix proposal for 8191813.
>> webrev - http://cr.openjdk.java.net/~rraghavan/8191813/webrev.00/
> No comments.
> So this style of call:
> mh_spreadInvoker.invokeExact(mh_spread_target, (Object) null);
> was changed from throwing IllegalArgumentException due to the "null"
> parameter to throwing NullPointerException. You've updated the test
> cleanly to switch from one exception to the other.
> Thumbs up! I believe this patch qualifies as trivial and does not
> need to wait for 24 hours. I leave it up to you whether you wait
> for a Compiler team member review also.
>> jbs - https://bugs.openjdk.java.net/browse/JDK-8191813
>> -- reported issue - After the latest sync from jdk/jdk the test
>> SpreadNullArg started to fail in tier1 on all platforms.
>> -- Found this SpreadNullArg.java failure Caused after JDK-8157246 fix.
>> jbs - https://bugs.openjdk.java.net/browse/JDK-8157246.
>> 'MHs.arrayLength, arrayElementGetter/Setter, arrayConstructor need to
>> specify invocation-time behavior'.
>> changeset - http://hg.openjdk.java.net/jdk/jdk/rev/76519338df34
>> - So now with 8157246 fix, if method handle is invoked with a null
>> array reference, NullPointerException will be thrown. (Not
>> - So above fix proposal in SpreadNullArg.java to expect
>> NullPointerException after 8157246 changes.
More information about the hotspot-compiler-dev